fix: 🐛 provide docs how to use registerIconLibrary with UMD bundle#433
Merged
mariohamann merged 2 commits intomainfrom Sep 27, 2023
Merged
fix: 🐛 provide docs how to use registerIconLibrary with UMD bundle#433mariohamann merged 2 commits intomainfrom
mariohamann merged 2 commits intomainfrom
Conversation
9 tasks
yoezlem
approved these changes
Sep 26, 2023
azraefendic
approved these changes
Sep 26, 2023
Vahid1919
approved these changes
Sep 26, 2023
yoezlem
pushed a commit
that referenced
this pull request
Oct 9, 2023
) ## Description: *PR notes: Please describe the changes in this PR.* 1. I updated the docs for `sd-icon`. 2. I fixed the tests using the documented approach. ## Definition of Reviewable: *PR notes: Irrelevant elements should be removed.* - [x] Documentation is created/updated - [x] relevant tickets are linked - [x] PR is assigned to project board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
PR notes: Please describe the changes in this PR.
sd-icon.Definition of Reviewable:
PR notes: Irrelevant elements should be removed.