Skip to content

Conversation

@chekkan
Copy link
Contributor

@chekkan chekkan commented Mar 8, 2019

Our Jira projects are configured to use Spikes. However, the rest api for jira issues seems to return the issue Type with space after the work "Spikes".

This fixes the issue so that the type is not null after select statement in JiraMapper.cs Line 127

var type = (from t in _config.TypeMap.Types where t.Source == issue.Type select t.Target)
    .FirstOrDefault();

if (type != null)
...

Before
console-output
spikeissuetypewithoutextraspace

After
consoleoutputafter
spikeissuetypewithoutextraspace

@chekkan chekkan marked this pull request as ready for review March 8, 2019 10:36
@MOlausson
Copy link
Member

Hi @chekkan, thanks for bringing this to our attention. I'll review the change but may have to implement it more generically since in my opinion all fields need to be trimmed. I'll have a chat with the other devs.

@MOlausson MOlausson merged commit 94762c2 into solidify:master Mar 22, 2019
@chekkan chekkan deleted the feature/spikes_with_space branch July 31, 2019 12:37
garooka pushed a commit to garooka/jira-azuredevops-migrator-extetion that referenced this pull request Sep 13, 2023
fixes Spikes mapping issue: Trim space on JiraItem type
garooka pushed a commit to garooka/jira-azuredevops-migrator-extetion that referenced this pull request Sep 13, 2023
fixes Spikes mapping issue: Trim space on JiraItem type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants