Skip to content

Conversation

@thetarnav
Copy link
Member

@thetarnav thetarnav commented Mar 10, 2023

Took some time to rewrite the logic of the Header component to remove the amount of state synchronization in effects and instead derive as much state as possible.
It works fine on chrome / ff on windows, but I have no idea if I didn't break something on safari.
Not sure about keeping styles in the styles store. there might be a better solution.
the styles are now fully derived as well.
I would some help in making sure everything works on Safari

@thetarnav thetarnav requested a review from aquaductape March 10, 2023 20:53
@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2023

⚠️ No Changeset found

Latest commit: 624b793

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aquaductape aquaductape merged commit 9d690e9 into main Mar 17, 2023
@thetarnav thetarnav deleted the site-updates branch March 18, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants