Site updates - refactor Header.tsx #346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took some time to rewrite the logic of the Header component to remove the amount of state synchronization in effects and instead derive as much state as possible.
It works fine on chrome / ff on windows, but I have no idea if I didn't break something on safari.
Not sure about keeping styles in the styles store. there might be a better solution.the styles are now fully derived as well.
I would some help in making sure everything works on Safari