CloudFlare "Auto Minify" breaks SolidJS

[Moudoux]

Describe the bug

I'm not sure if this is just solidjs itself, or related to solid-start as well, but I'm creating the bug here in any case. I am using solid-start with SSR enabled for an app, running behind CloudFlare. Enabling the "Auto Minify" options, in the Speed -> Optimizations tab, causes solidjs reactivity to break. Since this is not related to some specific code, I don't have a repo or page to provide, since CloudFlare is needed to test and verify the issue.

The console logs the following error when auto minify is enabled:

There are no issues at all if I disable the auto minify option.

Your Example Website or App

not applicable, any reactive app will produce the behavior

Steps to Reproduce the Bug or Issue

1. Create or use a solidjs app with some reactivity features
2. Deploy it and use CloudFlare in front of it
3. Enable all "Auto minify" options in Speed -> Optimization
4. Go to the deployed app and reactivity will be broken

Expected behavior

I expect the solidjs app to work without issues even with these settings enabled.

Screenshots or Videos

No response

Platform

• OS: Tested on Windows and Linux
• Browser: Brave
• Version: v1.47.171

Additional context

I'm not sure if it's possible to solve this issue, but in that case there should be some sort of documentation of the issue, so other users can prevent this from happening.

[ryansolid]

HTML files are minified dynamically by removing comments and unnecessary empty lines only.
https://support.cloudflare.com/hc/en-us/articles/200168196-Using-Cloudflare-Auto-Minify

Removing comments will break hydration.

Yeah I will move this issue so they will make a note here: https://docs.solidjs.com/guides/how-to-guides/deployment/deploying-to-cloudflare

[michaelessiet]

I'll add this as a footnote to the deploying to cloudflare guide

[michaelessiet]

Not sure if this is enough information. I can't really test is as I don't have a site to test it with. If more information needs to be added to this please let me know

[ryansolid]

Seems fine. Thanks Michael.