support arrays in search params tweaks

Author: ryansolid

.changeset/fresh-wasps-explode.md

@@ -0,0 +1,5 @@
+---
+"@solidjs/router": patch
+---
+
+Support arrays in Search Params

src/routing.ts

@@ -231,7 +231,7 @@ export function getRouteMatches(branches: Branch[], location: string): RouteMatc
 function createLocation(
   path: Accessor<string>,
   state: Accessor<any>,
-  queryWrapper?: (getQuery: () => Params) => Params
+  queryWrapper?: (getQuery: () => SearchParams) => SearchParams
 ): Location {
   const origin = new URL(mockBase);
   const url = createMemo<URL>(
@@ -254,7 +254,7 @@ function createLocation(
   const search = createMemo(() => url().search, true);
   const hash = createMemo(() => url().hash);
   const key = () => "";
-  const queryFn = on(search, () => extractSearchParams(url())) as () => Params;
+  const queryFn = on(search, () => extractSearchParams(url())) as () => SearchParams;
 
   return {
     get pathname() {

src/types.ts

@@ -167,7 +167,7 @@ export interface RouterUtils {
   go(delta: number): void;
   beforeLeave: BeforeLeaveLifecycle;
   paramsWrapper: (getParams: () => Params, branches: () => Branch[]) => Params;
-  queryWrapper: (getQuery: () => Params) => Params;
+  queryWrapper: (getQuery: () => SearchParams) => SearchParams;
 }
 
 export interface RouterContext {

src/utils.ts

@@ -51,12 +51,9 @@ export function extractSearchParams(url: URL): SearchParams {
   const params: SearchParams = {};
   url.searchParams.forEach((value, key) => {
     if (key in params) {
-      params[key] = Array.isArray(params[key])
-        ? ([...params[key], value] as string[])
-        : ([params[key], value] as string[]);
-    } else {
-      params[key] = value;
-    }
+      if (Array.isArray(params[key])) (params[key] as string[]).push(value);
+      else params[key] = [params[key] as string, value];
+    } else params[key] = value;
   });
   return params;
 }