-
Notifications
You must be signed in to change notification settings - Fork 198
add internal patch marker #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
all internal patches will be add below the marker. This eases internal patch management when public patches change Signed-off-by: Guohan Lu <lguohan@gmail.com>
|
Nit: will be added I wondor if adding a directory |
|
@paulmenzel , for all sonic repos, we have a unified way to introduce additional patch on those repro. The patch will first patch those repros, and then build those repo. In the internal repo, we will then first patch this series file, and then use the patches series file to patch the kernel build. |
Sorry, I do not understand your comment. How does that contradict having a directory |
|
let me try again. so, if we change the sonic-linux-kernel build process and introduce a new directory Therefore, we have design a unified way to patch each submodule in The unified approach can be found here. https://github.com/Azure/sonic-buildimage/blob/master/slave.mk#L371 |
Signed-off-by: Guohan Lu <lguohan@gmail.com>
all internal patches will be added below the marker. This eases internal patch management when public patches change Signed-off-by: Guohan Lu <lguohan@gmail.com>
all internal patches will be added below the marker. This eases internal patch management when public patches change Signed-off-by: Guohan Lu <lguohan@gmail.com>
**What I did** Correct real time CPU Utilization calculation **Why I did it** Now in procdockerstatsd script we iterate all processes every 2 minutes and ingest into state_db, https://psutil.readthedocs.io/en/latest/#psutil.cpu_percent, psutil supports both blocking and non-blocking way, and we prefer to use non-blocking way, thus now psutil.cpu_percent() used is to calculate CPU utilization since last time being triggered, current implementation will create new process object in below lines every time: for process in psutil.process_iter(['pid', 'ppid', 'memory_percent', 'cpu_percent', 'create_time', 'cmdline']): In order to get correct CPU utilization from last 2 minutes, we need store process object into some variable, so that every iteration will first lookup all_process_obj member and use existing process object, otherwise create new object for further use. And clean up the dead process object in case some process crashes. **How I verified it** Verified by UT and will check by ksoftirqd reproduced case.
all internal patches will be add below the marker. This eases
internal patch management when public patches change
Signed-off-by: Guohan Lu lguohan@gmail.com