Skip to content

Unable to add a message to an existing tag #54

@markochk

Description

@markochk

Creating a tag and later trying to add a message to it, it fails (Commit window doesn't open, it just prints the error message):

$ git tag test-tag 
$ git tag test-tag -a -f
hint: Waiting for your editor to close the file... 
(re.sonny.Commit:2): Gjs-CRITICAL **: 20:38:19.094: JS ERROR: TypeError: commentLines[3] is undefined
parse@file:///app/share/re.sonny.Commit/scm.js:38:21
openEditor@file:///app/share/re.sonny.Commit/application.js:104:12
Application/<@file:///app/share/re.sonny.Commit/application.js:35:15
main@file:///app/share/re.sonny.Commit/main.js:51:22
@file:///app/bin/re.sonny.Commit:12:5

fatal: no tag message?

If I create a tag with a message and later try to change it, it also fails. The only difference is in the last line:

$ git tag test-tag -a
$ git tag test-tag -a -f
hint: Waiting for your editor to close the file... 
(re.sonny.Commit:2): Gjs-CRITICAL **: 20:38:49.572: JS ERROR: TypeError: commentLines[3] is undefined
parse@file:///app/share/re.sonny.Commit/scm.js:38:21
openEditor@file:///app/share/re.sonny.Commit/application.js:104:12
Application/<@file:///app/share/re.sonny.Commit/application.js:35:15
main@file:///app/share/re.sonny.Commit/main.js:51:22
@file:///app/bin/re.sonny.Commit:12:5

Updated tag 'test-tag' (was 37ac31b)

If I remove the editor = flatpak run --file-forwarding re.sonny.Commit @@ line in .gitconfig, both scenarios work properly and add/change the tag message.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions