SIcon Size with Number type. #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefashkaa
approved these changes
Dec 10, 2020
stefashkaa
added a commit
that referenced
this pull request
Dec 17, 2020
* Refactored stories props, updated UI Lib version and removed bottom border for Horizontal Menu. * Fixed SIcon size with number type. (#102) * PSS-227: WEB UI: Design System: Add theming service (#103) * Add theming service * Update version * STabs Rounded Type Styles Fix (#104) * Fixed rounded STabs styles, Updated UI Lib version. * Fixed merge bug. Co-authored-by: Stefan Popov <stefanpopov@list.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Size prop didn't work as expected. It was a string type always and that's why we couldn't set the size in
size='16'style.I fixed this behaviour.