Add input inner offset for s-input-type #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexnatalia
reviewed
Feb 25, 2021
src/styles/select.scss
Outdated
| .el-select { | ||
| .el-input { | ||
| &--prefix { | ||
| .el-input__inner{ |
Contributor
There was a problem hiding this comment.
Could you add space before the brace, please? And I'm not sure that the next value should be static.
Contributor
Author
There was a problem hiding this comment.
I've added a local variables for select prefix slot and use them to calc el-input__inner padding now
alexnatalia
reviewed
Feb 25, 2021
alexnatalia
approved these changes
Feb 25, 2021
Nikita-Polyakov
added a commit
that referenced
this pull request
Feb 25, 2021
* Add input inner offset for s-input-type (#128) * add input inner offset for s-input-type * add option padding * up library version to 0.7.5 * fixes after review * use variables in offsets * remove test code from story
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.