Skip to content

Conversation

@alexnatalia
Copy link
Contributor

@alexnatalia alexnatalia commented May 19, 2021

Task

PSS-352: WEB UI. Input fields. Numbers are not divided by discharge.

Changes

  • SFloatInput: Added Number Formatting.

@alexnatalia alexnatalia requested a review from stefashkaa May 19, 2021 11:40
@Nikita-Polyakov
Copy link
Contributor

Nikita-Polyakov commented May 20, 2021

numformatting

I think we should fire an input event with a non-localized string. Converting this value to a string with a number without delimiters, on the application side is additional work

Example of possible flow:
s-float component recieves props value -> transform value to localized string 'innerValue' (using computed) -> pass :value="innerValue" to s-input

handleInput call -> transform localized string to number string -> emit it

@alexnatalia alexnatalia changed the title PSS-601: SFloatInput - Added Number Formatting PSS-352: SFloatInput - Added Number Formatting May 22, 2021
@alexnatalia alexnatalia removed the wip label May 23, 2021
@alexnatalia alexnatalia merged commit be43608 into develop May 24, 2021
@alexnatalia alexnatalia deleted the feature/pss-601-number-formatting branch May 24, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants