Scroll sections implementation #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asmadek
approved these changes
Jul 20, 2020
Pobepto
reviewed
Jul 20, 2020
| return | ||
| } | ||
| this.menuItems = this.$children | ||
| window.addEventListener('scroll', this.handleScroll) |
There was a problem hiding this comment.
Should the event be cleaned up after the object is destroyed?
I think we should add removeEventListener
Contributor
Author
There was a problem hiding this comment.
yeah, thx. will add it in the next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've implemented scroll sections component which is used for changing routes and set active link when user is scrolling.
Works done