Skip to content

Improve dialog and json input components #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 21, 2020
Merged

Improve dialog and json input components #57

merged 3 commits into from
Sep 21, 2020

Conversation

@stefashkaa
Copy link
Contributor

@stefashkaa stefashkaa commented Sep 21, 2020

Description

I've added readonly property for json-editor and automatically calculated top property for the dialog.

Works done

  • Add readonly property for the JSON input
  • Add automatically calculated top property for the dialog

@stefashkaa stefashkaa requested a review from Pobepto September 21, 2020 05:55
@stefashkaa stefashkaa merged commit 00da752 into develop Sep 21, 2020
@stefashkaa stefashkaa deleted the feature/improve-dialog-and-json-input branch September 21, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Pobepto Pobepto Pobepto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stefashkaa @Pobepto