Extend Docker images and CI #442
Conversation
kfriedberger
force-pushed
the
feat/docker-images
branch
4 times, most recently
from
56a7217 to
8771eab
Compare
kfriedberger
force-pushed
the
feat/docker-images
branch
7 times, most recently
from
4f97f8f to
b0b890f
Compare
…, such as x64 and arm64.
and extend SolverContextFactory with more checks on operating systems and architecture.
kfriedberger
force-pushed
the
feat/docker-images
branch
from
afa79f7 to
1a88f53
Compare
The file was only used for testing.
daniel-raffler
left a comment
daniel-raffler
left a comment
There was a problem hiding this comment.
We might want to wait for feedback on the java-project-template issue. Otherwise this looks good to me!
| FROM ubuntu:20.04 | ||
|
|
||
| ENV DEBIAN_FRONTEND=noninteractive | ||
| ENV TZ=UTC | ||
|
|
||
| RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
| ant \ | ||
| curl \ | ||
| git \ | ||
| jq \ | ||
| openjdk-11-jre-headless \ | ||
| openjdk-11-jdk-headless \ | ||
| wget \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| ENV LANG C.UTF-8 | ||
|
|
There was a problem hiding this comment.
Are the changes here just temporary due to the java-project-template issue you mentioned? Otherwise, I think that something like FROM --platform=?? registry.gitlab.com/sosy-lab/software/java-project-template/test:jdk-11 could be used to pull the image for a specific architecture.
There was a problem hiding this comment.
Yes, temporary, until further notice 😄, e.g., until there is one multi-arch Docker image in the registry where we can inherit from.
FROM --platform <ARCH> <TAG> can be used to select one of several architectures from a multi-arch Docker image, but not the other way. See https://docs.docker.com/reference/dockerfile/#from . I do not expect it to work in this case.
I am unsure who will work on issues for |
2 participants
With the support of more architectures we should also extend our test-coverage for those architectures.
This PR provides several smaller steps towards this:
Screenshot of the pipeline:
This PR violates the rule to reuse SoSy-Lab common project files for building and testing applications and libraries. However, this is due to the lack of support for multiple architectures from the common project template. We opened an issue there: https://gitlab.com/sosy-lab/software/java-project-template/-/issues/7 and aim for a merge of scripts into the common project template.