Include submission logging

[sayomaki]

No description provided.

[sentry]

Bug: Removing on_conflict from Repo.insert with conflict_target causes Ecto.ConstraintError on update attempts.
_{Severity: CRITICAL | Confidence: 1.00}

🔍 Detailed Analysis

The code change removes the on_conflict clause from Repo.insert while retaining conflict_target: [:submission_id, :question_id]. According to Ecto's behavior, this defaults to :raise on unique constraint violation. When a student attempts to update an existing answer, the unique constraint on (submission_id, question_id) will be violated, raising an Ecto.ConstraintError and crashing the assessment-saving endpoint.

💡 Suggested Fix

Restore the on_conflict clause with a set action to correctly handle updates for existing answers, ensuring the insert_or_update_answer function behaves as intended.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: lib/cadet/assessments/assessments.ex#L2998-L3003

Potential issue: The code change removes the `on_conflict` clause from `Repo.insert`
while retaining `conflict_target: [:submission_id, :question_id]`. According to Ecto's
behavior, this defaults to `:raise` on unique constraint violation. When a student
attempts to update an existing answer, the unique constraint on `(submission_id,
question_id)` will be violated, raising an `Ecto.ConstraintError` and crashing the
assessment-saving endpoint.

_{Did we get this right? 👍 / 👎 to inform future reviews.}