Skip to content

Refactor Assessment files naming #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 3, 2018
Merged

Refactor Assessment files naming #149

merged 17 commits into from
Jul 3, 2018

Conversation

@remo5000
Copy link
Contributor

@remo5000 remo5000 commented Jul 3, 2018

Features

  • Assessment/index is now the listing, instead of Assessment/AssessmentListing. This is because everything is redirected to the listing page first, making it the "index".
  • Assessment/AssessmentWorkspace is now the component that spawns a workspace. It used to be the index, but is not.
  • Renamed props and styles to reflect the above changes

@remo5000 remo5000 requested a review from ning-y July 3, 2018 05:49
@coveralls
Copy link

coveralls commented Jul 3, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 149

  • 63 of 91 (69.23%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.411%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/academy/grading/index.tsx 0 1 0.0%
src/components/academy/index.tsx 2 3 66.67%
src/components/assessment/AssessmentWorkspace.tsx 24 28 85.71%
src/components/assessment/index.tsx 22 27 81.48%
src/containers/assessment/index.ts 7 12 58.33%
src/containers/assessment/AssessmentWorkspaceContainer.ts 8 20 40.0%
Totals Coverage Status
Change from base Build 144: 0.0%
Covered Lines: 1162
Relevant Lines: 3276
💛 - Coveralls

@remo5000
Rename file using Git
834bee7 
Renaming a file using the system does not cause git to register a
modification. I used git mv twice to get over this. In the future, just
using git mv the first time should suffice
@remo5000
Copy link
Contributor Author

remo5000 commented Jul 3, 2018

Travis failed due to a renaming issue, should be fixed now.

@ning-y ning-y merged commit b5ac72a into master Jul 3, 2018
@ning-y ning-y deleted the listing-semantics branch July 17, 2018 11:16
@ning-y ning-y mentioned this pull request Jul 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ning-y ning-y ning-y approved these changes

Assignees

No one assigned

Labels

_refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@remo5000 @coveralls @ning-y