Adding of grading status to assessment overview #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump phoenix from 1.3.4 to 1.4.0 (source-academy#299)
Pull Request Test Coverage Report for Build 2166
💛 - Coveralls |
indocomsoft
requested changes
Jan 9, 2019
Member
indocomsoft
left a comment
indocomsoft
left a comment
There was a problem hiding this comment.
Looks good, but you need to add tests for assessments.ex, lines 211 and 212
indocomsoft
requested changes
Jan 9, 2019
indocomsoft
requested changes
Jan 10, 2019
Member
indocomsoft
left a comment
indocomsoft
left a comment
There was a problem hiding this comment.
Sorry, some more nitpicking but should be good to merge afterwards.
lib/cadet/assessments/assessments.ex
Outdated
|
|
||
| defp build_grading_status(q_count, g_count) do | ||
| cond do | ||
| g_count == nil || g_count == 0 -> :none |
Member
There was a problem hiding this comment.
This conditional clause is useless since this is captured by true -> :none as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes if assessment has been fully graded.