Implement Assessment.QuestionType entities #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 267
💛 - Coveralls |
indocomsoft
force-pushed
the
question-types
branch
from
015774a to
194d956
Compare
indocomsoft
force-pushed
the
question-types
branch
from
194d956 to
1ea3562
Compare
indocomsoft
changed the title
indocomsoft
force-pushed
the
question-types
branch
from
3dcd91d to
7c27cfc
Compare
evansb
requested changes
May 26, 2018
| embedded_schema do | ||
| field(:content, :string) | ||
| field(:solution_template, :string) | ||
| field(:solution_header, :string) |
Contributor
There was a problem hiding this comment.
This should be optional field, I think it's needed only for path
lib/cadet/assessments.ex
Outdated
| |> ProgrammingQuestion.changeset(%{raw_programmingquestion: json_attr}) | ||
| end | ||
|
|
||
| def create_programmingquestion(attr = %{}) do |
Contributor
There was a problem hiding this comment.
create_programming_question is a bit easier to read.
lib/cadet/assessments.ex
Outdated
| |> MCQQuestion.changeset(%{raw_mcqquestion: json_attr}) | ||
| end | ||
|
|
||
| def create_mcqquestion(attr = %{}) do |
Contributor
There was a problem hiding this comment.
create_multiple_choice_question
Member
Author
|
Done. |
evansb
approved these changes
Jun 8, 2018
sreycodes
pushed a commit
that referenced
this pull request
Jun 11, 2018
* Implement question types * Add tests * Add library to ProgrammingQuestion * Remove debug output and mix format * Fix according to code review * Bypass coveralls * Comment out assessments context to allow merging
indocomsoft
added a commit
that referenced
this pull request
Aug 17, 2018
* Implement question types * Add tests * Add library to ProgrammingQuestion * Remove debug output and mix format * Fix according to code review * Bypass coveralls * Comment out assessments context to allow merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not yet written tests for lib/cadet/assessments.ex because @sreycodes is still writing the code for the assessment context.