Add dialyzer static code analysis and fix dialyzer offenses #6
Conversation
Pull Request Test Coverage Report for Build 100
💛 - Coveralls |
|
Sorry, can you justify your decision of using Dialyzer?
Furthermore it will cause more friction to the developers that have to learn/lookup the types. |
|
Ah well, it was just a thought. I trust your judgment on this. Although I've noticed some errors generated that might be legitimate errors like Maybe a better approach to run it once in a while just as a quick check and fix instead of imposing it on travis? |
|
I think that’s habit from Ecto 1, it should be %{} now. It used to be :empty to distinguish empty form
…Sent from my iPhone
On 19 Apr 2018, at 8:09 PM, Julius Putra Tanu Setiaji ***@***.***> wrote:
Ah well, it was just a thought. I trust your judgment on this.
Although I've noticed some errors generated that might be legitimate errors like changeset(entity, params \\ :empty) with :empty instead of %{}, and some pattern matching in a case that is unreachable because of the pattern match in the parameter.
Maybe a better approach to run it once in a while just as a quick check and fix instead of imposing it on travis?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Alright, I'll fix stuffs that dialyxir complains about that are actually legit in this PR. Maybe keep |
|
@evansb bump |
* Add dialyzer * Fix dialyzer offenses * Fix credo offense * Add try/rescue in mix tasks * Add ex_unit to dialyzer * Add path to dialyzer * Use travis matrix instead * Test override travis env * Fix dialyzer conn_case * Remove travis dev env * Remove dialyzer no_return * Remove mix dialyzer from travis script
No description provided.