Fixed achievement-related issues #1753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split updateGoalProgress into self and admin, with validation. Renamed variableXp to isVariableXp Changed some critical endpoints to comply with v2 backend.
…my/cadet-frontend into sa2122-achievements
Handling events now happens every 5 seconds if there are events queued. Also removed redundant dependency between goal and achievement when adding goals to achievements.
Any changes done in the inferencer will not affect the copy in the overall state.
Inferencer now makes a deep copy of every achievement/goal it is constructed with so as to not touch the overall state.
…my/cadet-frontend into sa2122-achievements
Pull Request Test Coverage Report for Build 892287120
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1752 by adding a condition in processEvent().
Resolves #1439 by using moment.js in the achievement DateHelper to prettify dates.
Type of change
How to test
Run code while not logged in, no "Please log in again" pop out should appear.
Set achievements with different deadlines, see that the deadline listed in the achievement dashboard looks reasonable.
Checklist