Skip to content

Conversation

@gok99
Copy link
Contributor

@gok99 gok99 commented Aug 4, 2021

Description

  • Points course-specific game assets (e.g story txts, chapter assets, chapter preview images) to the course coded s3 urls, and general game assets (e.g Entry scene and Story Simulator assets, UI assets) to the non course coded urls, with a courseCoded flag in the toS3Path function

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@angelsl
Copy link
Contributor

angelsl commented Aug 4, 2021

Changed it to get the asset prefix entirely from the backend.

@chownces
Copy link
Contributor

chownces commented Aug 5, 2021

lgtm. might wanna add assetsPrefix to src/pages/__tests__/localStorage.test.ts to standardise it (even though its undefined)

not tested yet as assets are not renamed atm

@gok99
Copy link
Contributor Author

gok99 commented Aug 5, 2021

tested with updated backend, and all seems to work!

changed the game module remote path to a function, will update the modules side accordingly

@angelsl angelsl merged commit 69354ca into source-academy:multitenant/dev Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants