Skip to content

Fix game save request url #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 8, 2021
Merged

Fix game save request url #1909

merged 5 commits into from
Aug 8, 2021

Conversation

@gok99
Copy link
Contributor

@gok99 gok99 commented Aug 7, 2021 •
edited
Loading

Description

  • Adds 'courses' to game save request url
  • Fixes setting of fetched gamestate
  • Fixes mockChapter paths

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have tested this code

@coveralls
Copy link

coveralls commented Aug 7, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1109181124

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 30.884%
Totals Coverage Status
Change from base Build 1109180795: 0.0%
Covered Lines: 3413
Relevant Lines: 10314
💛 - Coveralls

chownces
chownces approved these changes Aug 8, 2021
View reviewed changes
Copy link
Contributor

@chownces chownces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chownces chownces merged commit 3ea746a into source-academy:master Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chownces chownces chownces approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gok99 @coveralls @chownces