Skip to content

Update stories dependencies (major versions) #2687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 24, 2023
Merged

Update stories dependencies (major versions) #2687

merged 4 commits into from
Sep 24, 2023

Conversation

@RichDom2185
Copy link
Member

Description

There was a massive update to a bunch of packages in the remark ecosystem recently. This PR updates those dependencies, also resolving their associated breaking changes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185
Upgrade most stories dependencies
8953374
@RichDom2185
Bump rehype-react
69cbec5 
Also fixed type errors and addressed breaking changes.
@RichDom2185 RichDom2185 self-assigned this Sep 22, 2023
@RichDom2185 RichDom2185 enabled auto-merge (squash) September 22, 2023 19:42
@RichDom2185 RichDom2185 changed the title Update stories dependencies (major version) Update stories dependencies (major versions) Sep 22, 2023
@RichDom2185 RichDom2185 enabled auto-merge (squash) September 22, 2023 19:42
@RichDom2185 RichDom2185 enabled auto-merge (squash) September 22, 2023 20:02
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6278579827

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 37.278%
Totals Coverage Status
Change from base Build 6219355459: 0.0%
Covered Lines: 5709
Relevant Lines: 14398
💛 - Coveralls

martin-henz
martin-henz approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have not tested this.

@RichDom2185 RichDom2185 merged commit 6befa11 into master Sep 24, 2023
@RichDom2185 RichDom2185 deleted the stories-deps-major branch September 24, 2023 15:09
RichDom2185 added a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Oct 5, 2023
@RichDom2185
Update stories dependencies (major versions) (source-academy#2687)
184cd0d 
* Upgrade most stories dependencies

* Bump rehype-react

Also fixed type errors and addressed breaking changes.

* Fix test configuration
RichDom2185 added a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Oct 5, 2023
@RichDom2185
Update stories dependencies (major versions) (source-academy#2687)
7b30f44 
* Upgrade most stories dependencies

* Bump rehype-react

Also fixed type errors and addressed breaking changes.

* Fix test configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martin-henz martin-henz martin-henz approved these changes

@chownces chownces Awaiting requested review from chownces

Assignees

@RichDom2185 RichDom2185

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RichDom2185 @coveralls @martin-henz