Fix stories spurious 404 errors, allow stories to be configurable per-course #2721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update persistence, types * Create toggle switches
* Update navigation bar for selective rendering * Update stories routes to be under "/courses/:courseId" * Add loader to stories routes
Only contact the stories backend when stories are enabled in the current course configuration.
Pull Request Test Coverage Report for Build 7766771400
💛 - Coveralls |
Also adds the dispatch logic to previously missed action handlers.
sayomaki
approved these changes
Jan 17, 2024
Backend PR has been merged! I'll set this to merge on successful CI. Thanks! |
CYX22222003
pushed a commit
to CYX22222003/frontendCYX
that referenced
this pull request
Feb 9, 2024
…-course (source-academy#2721) * Add `enableStories` field to course config * Update persistence, types * Create toggle switches * Use relative route paths for stories components * Only render Stories button when enabled for course * Update navigation bar for selective rendering * Update stories routes to be under "/courses/:courseId" * Add loader to stories routes * Fix spurious 404 errors Only contact the stories backend when stories are enabled in the current course configuration. * Create wrapper action to clear stories state * Handle stories state change on course config change * Update failing snapshots * Move clearing logic to BackendSaga Also adds the dispatch logic to previously missed action handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relevant backend PR: source-academy/backend#1053 (must be merged before this can be merged)
Please refer to commits for full list of changes.
Allows stories state (enabled/disabled) to be configured on a per-course basis. When it is disabled, the frontend won't attempt to contact the stories backend for that particular course, thus removing the cause of the 404 error.
Also moves stories' routes under
/courses/:courseId, since it is now course-dependent.Type of change
How to test
Everything still works.
Checklist