Skip to content

Conversation

@RichDom2185
Copy link
Member

Description

Moves away from the connect Higher-Order-Component in favour of the useDispatch and useSelector hooks.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Everything should still work.

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 self-assigned this Feb 3, 2024
Improves typing and consistency with the rest of the codebase.
@coveralls
Copy link

coveralls commented Feb 3, 2024

Pull Request Test Coverage Report for Build 7787363563

  • -68 of 68 (0.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 37.202%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/missionCreator/MissionCreator.tsx 0 9 0.0%
src/pages/academy/grading/subcomponents/GradingEditor.tsx 0 9 0.0%
src/pages/academy/groundControl/subcomponents/DefaultChapterSelect.tsx 0 12 0.0%
src/pages/achievement/control/AchievementControl.tsx 0 18 0.0%
src/pages/achievement/subcomponents/AchievementDashboard.tsx 0 20 0.0%
Files with Coverage Reduction New Missed Lines %
src/commons/missionCreator/MissionCreator.tsx 1 0.0%
Totals Coverage Status
Change from base Build 7787163727: -0.02%
Covered Lines: 5723
Relevant Lines: 14458

💛 - Coveralls

@RichDom2185 RichDom2185 merged commit 88d5b41 into master Feb 7, 2024
@RichDom2185 RichDom2185 deleted the no-connect-hoc-1 branch February 7, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants