-
Couldn't load subscription status.
- Fork 174
Game: Add additional keyboard inputs for interactions with the game #2786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Game: Add additional keyboard inputs for interactions with the game #2786
Conversation
|
Is this PR ready, or still draft? |
Pull Request Test Coverage Report for Build 8123662669Details
💛 - Coveralls |
|
This PR is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick sweep through the code, looks alright so far. Will do another pass after the meeting next week - good work @reginateh @CYX22222003!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments, after this it should be GTM :)
…tend into keyboardShortcuts
…tend into keyboardShortcuts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your hard work @reginateh @CYX22222003 👍
Description
Adds additional key bindings for the following interactions:
Transition out the location notification
Select location under the Move mode
UI changes to let the users know there are keyboard shortcuts available:
This closes issue #2676.
Type of change
How to test
Test with existing story files.
Checklist