Skip to content

Conversation

@reginateh
Copy link
Contributor

@reginateh reginateh commented Feb 16, 2024

Description

Adds additional key bindings for the following interactions:

Key Binding Action
Space Show the next line of dialogue
Transition out the location notification
E Enter and exit the Explore mode
V Enter and exit the Move mode
T Enter and exit the Talk mode
Numbers Select dialogue topic under the Talk mode
Select location under the Move mode

UI changes to let the users know there are keyboard shortcuts available:

  1. Underline the key bindings on the mode selection buttons

image

  1. Number the options of locations and talk topics to their corresponding key

image
image

  1. Update the Binding page in the main menu to display new key bindings

image

This closes issue #2676.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Test with existing story files.

Checklist

  • I have tested this code
  • I have updated the documentation

@reginateh reginateh requested a review from lhw-1 February 16, 2024 15:31
@RichDom2185
Copy link
Member

Is this PR ready, or still draft?

@coveralls
Copy link

coveralls commented Feb 18, 2024

Pull Request Test Coverage Report for Build 8123662669

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 37.955%

Totals Coverage Status
Change from base Build 8121925695: 0.0%
Covered Lines: 5810
Relevant Lines: 14373

💛 - Coveralls

@reginateh reginateh marked this pull request as ready for review February 18, 2024 12:58
@reginateh
Copy link
Contributor Author

This PR is ready.

Copy link
Collaborator

@lhw-1 lhw-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick sweep through the code, looks alright so far. Will do another pass after the meeting next week - good work @reginateh @CYX22222003!

Copy link
Collaborator

@lhw-1 lhw-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments, after this it should be GTM :)

Copy link
Collaborator

@lhw-1 lhw-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your hard work @reginateh @CYX22222003 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants