Fix incorrect assessment overview memoization

[RichDom2185]

Description

Wow, this bug is 4 years old.

Indices should not be used as memoization keys. When switching between assessment types, the old image is still shown while the new one loads. Thus if the image load fails, nothing happens.

This fixes it, ensuring the entire assessment card is tied to the assessment ID, thus switching immediately updates the UI to loading state.

Also moves components to use FC instead of function calls as part of the fix (so that key prop works without drilling).

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Code quality improvements

How to test

Checklist

• I have tested this code
• I have updated the documentation

[coveralls]

Pull Request Test Coverage Report for Build 16962268299

Details

• 158 of 191 (82.72%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 43.462%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/commons/assessment/AssessmentInteractButton.tsx	52	62	83.87%
src/commons/assessment/AssessmentOverviewCard.tsx	78	101	77.23%

Totals
Change from base Build 16942913584:	0.01%
Covered Lines:	20655
Relevant Lines:	49720

---

💛 - Coveralls

[sayomaki]

LGTM, thanks! It seems that coveralls is working again.

(also, minor note but it is actually the list keys that is not being updated correctly causing react to think that the element was not updated)