Fix hollusion not rendering by: #825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removing dangerous getElementBy... - encapsulating canvas in ShapeDrawn - Passing canvas down to CanvasOutput - Made global canvas a constant. (copy out of it) - Rewriting all draw calls (curve, show, anaglyph, hollusion) to return a canvas.
…tend into fix-hollusion
Contributor
Author
|
Ps. I've manually tested all the paths for rune rendering, but the automated tests fail on me. Specifically: This is not something i have touched. |
Pull Request Test Coverage Report for Build 2879
💛 - Coveralls |
martin-henz
requested changes
Aug 11, 2019
Member
martin-henz
left a comment
martin-henz
left a comment
There was a problem hiding this comment.
Nice. A bigger frame rate leads to a much improved viewer experience. Should we increase the default value? Playing around a bit, 15 might be a sweet-spot. I can't see the difference between 15 and 20, but 10 seems to be a tad jittery.
Contributor
Author
Does this refer to the frame count (total 15 frames per 500ms) or, the frame rate (15 frames per second)? Increasing the frame count too much will cause the hollusion to take forever to load for the more complex designs. Anyway i updated the frame count from 3 --> 5. This is jittery, but its decent. |
martin-henz
approved these changes
Aug 12, 2019
jetkan-yk
added a commit
that referenced
this pull request
Aug 13, 2019
* Change default tab of ungraded assessments back to 'Task X' (#826) * Fix incorrect type declarations in IQuestion interface (#827) * Include null type in type declaration for grader, gradedAt in IQuestion * Update mocks such that Grading only renders for closed assessments * Add test to assert Grading tab is rendered when grader is non-null * Bump js-slang to 0.2.6 (#831) * Resizing editor to a larger size no longer makes it disappear (#832) * Update README.md (#810) * Version cadet (#798) * clean up libraries: removing streams and adding comment for lists stating the purpose to remain here * fixes wrong version in js console message * Default texts for data visualiser, inspector, env visualiser (#820) * Added default texts to be shown before Data/Insp/Env are used * Remove mentions of 'debugger;' * Modified default texts for Playground * Added links to textbook * Links now open in new tab * Conditional tab rendering in Playground (#808) * Conditional tab rendering for Playground * Data visualiser tab now only enabled for Source Chapter 2 and above * Inspector/Env Visualiser tabs now only enabled for Source Chapter 3 and above * Fix For Crashing in Source §1 & §2 * Integrate file upload system (#830) * Add basic dropzone for material uploading * Revamp dropzone styling * Finish file saving logics * Finish file retriving logics * Allow downloading of files * Allow deleting of materials * Rename academy materials to materialsUpload * Extract out materialTable * Add public tab for materials * Allow creating of materials folder * Update snapshot * Fix conflicts * Rename name to title * Close dialog after creating folder * Allow deleting of folder * Show index by folder id * Get directory tree info from backend * Improve UI for materialTable * Add material to specific folder * Add material folder to specific folder * Stay in current folder after add/delete actions * Improve table UI * Restructure files and folders * Remove duplicate file * Clean up repo * clean up libraries: removing streams and adding comment for lists sta… (#781) * clean up libraries: removing streams and adding comment for lists stating the purpose to remain here * addresses #781 (comment) * Improve display for sourcecast table (#834) * Update sourcecast table styling * Fix auto resizing * Display upload date in table * Clean up repo * Use material theme for material table (#835) * Fix hollusion not rendering by: (#825) * Fix hollusion not rendering by: - removing dangerous getElementBy... - encapsulating canvas in ShapeDrawn - Passing canvas down to CanvasOutput - Made global canvas a constant. (copy out of it) - Rewriting all draw calls (curve, show, anaglyph, hollusion) to return a canvas. * Linting fixes. * Increased number of hollusion frames as requested. * Data Viz: Resize viewport to fit drawing (#785) * Resize viewport to fit drawing * Fixed bug for circular lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.