Skip to content

Conversation

@yiwen101
Copy link
Contributor

@yiwen101 yiwen101 commented Oct 1, 2023

Rewrite index search and text search(and fix #913 and #905)

Have tested the index search in its coverage, and validity of the urls.Works well.

Know issues and next step:
1 Do not works for some symbols, big theta for example (though I do not think user can easily input and search for them as well)
2 Do not treat what is designed to be latex, roman, italic properly, now treat them as normal text.
3 No "see also in index, might be a good next step to add them.
4 Find clever and more robust way to test for the correctness of the url generated. (Other than manual tracing)
5 No automate test done on text search yet.

Also manually check for issue mentioned in #913 and #905 after rewriting. Unsurprisingly, they are all fixed.

I still kept the old "generateSearchData" as the frontend have not been updates yet, and the current frontend depends on it.

@yiwen101 yiwen101 requested a review from martin-henz October 1, 2023 09:41
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@martin-henz martin-henz merged commit 0f53ae6 into source-academy:master Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search: names not supported yet

2 participants