fix: expose content-range header #93
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise, browsers cannot access it, because it's not among the CORS-safelisted response headers:
https://developer.mozilla.org/en-US/docs/Glossary/CORS-safelisted_response_header
What I'm changing
Responses to range requests already include the
Content-Rangeheader.But browsers cannot read its value, because it's not among the CORS-safelisted response headers.
With this PR, the responses also include the header
Access-Control-Expose-Headers: Content-Range, to allow browsers to access theContent-Rangeheader.How I did it
I add the header, when the request was a range request.
How to test it
Go to https://observablehq.com/@severo/bug-in-source-coop-content-range-is-not-accessible
Or test the following in a browser (not in Node.js)
This function should return "Success" for any data file hosted by the proxy.
For example:
PR Checklist
and I have opened issue/PR #XXX to track the change.
Related Issues