Skip to content

fix: File empty on mv #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
venkat-ecov-dev merged 1 commit into from
Mar 7, 2025
Merged

fix: File empty on mv #51

venkat-ecov-dev merged 1 commit into from
Mar 7, 2025

Conversation

@venkat-ecov-dev
Copy link
Contributor

@venkat-ecov-dev venkat-ecov-dev commented Feb 27, 2025 •
edited
Loading

Related Issue(s):
##42

Proposed Changes:

  1. Created a custom copy_object function to interact with s3
  2. Handled server to server copy interaction in put api flow

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not main).
  • This PR has no breaking changes.
  • This PR contains only one commit.
  • I have updated or added new tests to cover the changes in this PR.
  • All tests are passing.
  • This PR affects the Source Cooperative Frontend & API,
    and I have opened issue/PR #XXX to track the change.

amit-ecovoice
amit-ecovoice reviewed Mar 4, 2025
View reviewed changes
src/main.rs
.copy_object((&copy_identifier_path).to_string(), key.clone(), None)
.await
{
Ok(_) => HttpResponse::NoContent().finish(),
Copy link

@amit-ecovoice amit-ecovoice Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we need to delete from source bucket after successful copy. Isn't it ?

Copy link
Contributor Author

@venkat-ecov-dev venkat-ecov-dev Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in local testing its deleting the file from source folder.

@venkat-ecov-dev venkat-ecov-dev merged commit 1f1b3fa into dev Mar 7, 2025
@venkat-ecov-dev venkat-ecov-dev deleted the fix-file-move-issue branch March 7, 2025 16:33
This was referenced Mar 11, 2025
Merged
Merged
venkat-ecov-dev added a commit that referenced this pull request Mar 11, 2025
@venkat-ecov-dev @source-coop-release
Updated release versions. (#56)
c8b44b6 
* fix: file empty on mv (#51)

* chore(dev): release 0.1.21 (#55)

Co-authored-by: source-coop-release[bot] <187876225+source-coop-release[bot]@users.noreply.github.com>
@source-coop-release source-coop-release bot mentioned this pull request May 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amit-ecovoice amit-ecovoice amit-ecovoice approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@venkat-ecov-dev @amit-ecovoice