Skip to content
This repository was archived by the owner on Nov 25, 2021. It is now read-only.

Commit 0433060

Browse files
committed
fix: correct typo in telemetryEvent
1 parent 6b41f2c commit 0433060

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

src/HoverOverlay.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export interface HoverOverlayProps {
6565
/** Called when the close button is clicked */
6666
onCloseButtonClick?: (event: React.MouseEvent<HTMLElement>) => void
6767

68-
logTelemetryEvent: (event: string) => void
68+
logTelemetryEvent: (event: string, data?: any) => void
6969
}
7070

7171
/** Returns true if the input is successful jump URL result */

src/hoverifier.test.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { distinctUntilChanged, filter, map } from 'rxjs/operators'
44
import { TestScheduler } from 'rxjs/testing'
55
import { Position } from 'vscode-languageserver-types'
66

7+
import { noop } from 'lodash'
78
import { propertyIsDefined } from './helpers'
89
import { createHoverifier, LOADER_DELAY, TOOLTIP_DISPLAY_DELAY } from './hoverifier'
910
import { HoverOverlayProps } from './HoverOverlay'
@@ -12,8 +13,6 @@ import { createHoverMerged, createStubHoverFetcher, createStubJumpURLFetcher } f
1213
import { clickPosition } from './testutils/mouse'
1314
import { LOADING } from './types'
1415

15-
const noop = () => undefined
16-
1716
describe('Hoverifier', () => {
1817
const dom = new DOM()
1918
// after(dom.cleanup)
@@ -43,7 +42,7 @@ describe('Hoverifier', () => {
4342
fetchHover: createStubHoverFetcher(hover, delayTime),
4443
fetchJumpURL: createStubJumpURLFetcher(defURL, delayTime),
4544
pushHistory: noop,
46-
logTelementryEvent: () => noop,
45+
logTelemetryEvent: noop,
4746
})
4847

4948
const positionJumps = new Subject<{

src/hoverifier.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ interface HoverifierOptions {
6161
/**
6262
* Called to log telemetry events
6363
*/
64-
logTelementryEvent: (eventLabel: string, eventProperties?: any) => void
64+
logTelemetryEvent: (event: string, data?: any) => void
6565

6666
fetchHover: HoverFetcher
6767
fetchJumpURL: JumpURLFetcher
@@ -207,7 +207,7 @@ export const createHoverifier = ({
207207
pushHistory,
208208
fetchHover,
209209
fetchJumpURL,
210-
logTelementryEvent,
210+
logTelemetryEvent,
211211
}: HoverifierOptions): Hoverifier => {
212212
// Internal state that is not exposed to the caller
213213
// Shared between all hoverified code views
@@ -452,7 +452,7 @@ export const createHoverifier = ({
452452
filter(HoverMerged.is)
453453
)
454454
.subscribe(() => {
455-
logTelementryEvent('SymbolHovered')
455+
logTelemetryEvent('SymbolHovered')
456456
})
457457
)
458458

@@ -536,7 +536,7 @@ export const createHoverifier = ({
536536
subscription.add(
537537
goToDefinitionClicks.subscribe(event => {
538538
// Telemetry
539-
logTelementryEvent('GoToDefClicked')
539+
logTelemetryEvent('GoToDefClicked')
540540

541541
// If we don't have a result yet that would be jumped to by the native <a> tag...
542542
if (!isJumpURL(container.values.definitionURLOrError)) {

0 commit comments

Comments
 (0)