fix(positions): don't return last character if target is code element

Previously, if the code element itself was the target, the last
character of the line was returned.
Return only the line number instead.

Author: felixfbecker

src/token_position.test.ts

@@ -209,6 +209,22 @@ describe('token_positions', () => {
                 }
             }
         })
+
+        it('returns only the line number when the code element itself is hovered', () => {
+            for (const { codeView, ...domOptions } of testcases) {
+                const target = domOptions.getCodeElementFromLineNumber(codeView, 1)!
+                const result = locateTarget(target, domOptions)
+                assert.deepStrictEqual(result, { line: 1 })
+            }
+        })
+
+        it('returns undefined when the code view itself is hovered', () => {
+            for (const { codeView, ...domOptions } of testcases) {
+                const target = codeView
+                const result = locateTarget(target, domOptions)
+                assert.strictEqual(result, undefined)
+            }
+        })
     })
 
     describe('getCodeElementsInRange()', () => {

src/token_position.ts

@@ -253,6 +253,13 @@ export function locateTarget(
     }
 
     const line = getLineNumberFromCodeElement(codeElement)
+
+    // If the hovered target was the code element itself or a parent,
+    // make sure to not return the last character
+    if (target === codeElement || target.contains(codeElement)) {
+        return { line }
+    }
+
     const part = getDiffCodePart && getDiffCodePart(codeElement)
 
     let character = 1