Skip to content
This repository was archived by the owner on Nov 25, 2021. It is now read-only.

Commit 2f2536c

Browse files
authored
feat: use react-loading-spinner (#33)
1 parent b4d2b22 commit 2f2536c

File tree

4 files changed

+11
-9
lines changed

4 files changed

+11
-9
lines changed

package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"author": "Felix Becker <felix@sourcegraph.com>",
3131
"dependencies": {
3232
"@sourcegraph/event-positions": "0.0.1",
33-
"@sourcegraph/icons": "^1.15.0",
33+
"@sourcegraph/react-loading-spinner": "0.0.2",
3434
"highlight.js": "^9.12.0",
3535
"lodash": "^4.17.10",
3636
"marked": "^0.4.0",

src/HoverOverlay.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@import '../node_modules/@sourcegraph/react-loading-spinner/lib/LoadingSpinner.css';
2+
13
.hover-overlay {
24
position: absolute;
35
width: 32rem;

src/HoverOverlay.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import Loader from '@sourcegraph/icons/lib/Loader'
1+
import { LoadingSpinner } from '@sourcegraph/react-loading-spinner'
22
import { castArray, noop, upperFirst } from 'lodash'
33
import AlertCircleOutlineIcon from 'mdi-react/AlertCircleOutlineIcon'
44
import CloseIcon from 'mdi-react/CloseIcon'
@@ -121,7 +121,7 @@ export const HoverOverlay: React.StatelessComponent<HoverOverlayProps> = ({
121121
<div className="hover-overlay__contents">
122122
{hoverOrError === LOADING ? (
123123
<div className="hover-overlay__row hover-overlay__loader-row">
124-
<Loader className="icon-inline" />
124+
<LoadingSpinner className="icon-inline" />
125125
</div>
126126
) : isErrorLike(hoverOrError) ? (
127127
<div className="hover-overlay__row hover-overlay__hover-error alert alert-danger">
@@ -181,7 +181,7 @@ export const HoverOverlay: React.StatelessComponent<HoverOverlayProps> = ({
181181
className="btn btn-secondary hover-overlay__action e2e-tooltip-j2d"
182182
onClick={onGoToDefinitionClick ? transformMouseEvent(onGoToDefinitionClick) : undefined}
183183
>
184-
Go to definition {definitionURLOrError === LOADING && <Loader className="icon-inline" />}
184+
Go to definition {definitionURLOrError === LOADING && <LoadingSpinner className="icon-inline" />}
185185
</ButtonOrLink>
186186
<ButtonOrLink
187187
linkComponent={linkComponent}

0 commit comments

Comments
 (0)