feat: remove "Find references" button

Author: sqs

README.md

@@ -12,7 +12,7 @@ Adds code intelligence to code views on the web. Used in [Sourcegraph](https://s
 
 - Listens to hover and click events on the code view
 - On mouse hovers, determines the line+column position, does an LSP hover request and renders it in a nice tooltip overlay at the token
-- Shows buttons for go-to-definition and find-references
+- Shows button for go-to-definition
 - When clicking a token, pins the tooltip to that token
 - Highlights the hovered token
 

src/HoverOverlay.tsx

@@ -45,13 +45,6 @@ export interface HoverOverlayProps<C = {}> {
      */
     definitionURLOrError?: typeof LOADING | { jumpURL: string } | null | ErrorLike
 
-    /**
-     * The URL to navigate to to view references.
-     * If loaded, is set as the href of the find-references button.
-     * If undefined or null, the button is disabled.
-     */
-    referencesURL?: string | null
-
     /** The position of the tooltip (assigned to `style`) */
     overlayPosition?: { left: number; top: number }
 
@@ -89,7 +82,6 @@ const transformMouseEvent = (handler: (event: MouseEvent) => void) => (event: Re
 
 export const HoverOverlay: <C>(props: HoverOverlayProps<C>) => React.ReactElement<any> = ({
     definitionURLOrError,
-    referencesURL,
     hoveredToken,
     hoverOrError,
     hoverRef,
@@ -193,17 +185,6 @@ export const HoverOverlay: <C>(props: HoverOverlayProps<C>) => React.ReactElemen
             >
                 Go to definition {definitionURLOrError === LOADING && <LoadingSpinner className="icon-inline" />}
             </ButtonOrLink>
-            {hoveredToken &&
-                referencesURL && (
-                    <ButtonOrLink
-                        linkComponent={linkComponent}
-                        // tslint:disable-next-line:jsx-no-lambda
-                        to={referencesURL}
-                        className="btn btn-secondary hover-overlay__action e2e-tooltip-find-refs"
-                    >
-                        Find references
-                    </ButtonOrLink>
-                )}
         </div>
         {definitionURLOrError === null ? (
             <div className="alert alert-info hover-overlay__alert-below">

src/hoverifier.ts

@@ -84,7 +84,6 @@ export interface HoverifierOptions<C extends object> {
 
     fetchHover: HoverFetcher<C>
     fetchJumpURL: JumpURLFetcher<C>
-    getReferencesURL: (hoverToken: HoveredToken & C) => string | null
 }
 
 /**
@@ -211,7 +210,6 @@ export interface HoverState {
 interface InternalHoverifierState<C extends object> {
     hoverOrError?: typeof LOADING | HoverMerged | null | ErrorLike
     definitionURLOrError?: typeof LOADING | { jumpURL: string } | null | ErrorLike
-    referencesURL?: string | null
 
     hoverOverlayIsFixed: boolean
 
@@ -263,7 +261,6 @@ const internalToExternalState = (internalState: InternalHoverifierState<{}>): Ho
                   isJumpURL(internalState.definitionURLOrError) || internalState.clickedGoToDefinition
                       ? internalState.definitionURLOrError
                       : undefined,
-              referencesURL: internalState.referencesURL,
               hoveredToken: internalState.hoveredToken,
               showCloseButton: internalState.hoverOverlayIsFixed,
           }
@@ -307,15 +304,13 @@ export function createHoverifier<C extends object>({
     pushHistory,
     fetchHover,
     fetchJumpURL,
-    getReferencesURL,
 }: HoverifierOptions<C>): Hoverifier<C> {
     // Internal state that is not exposed to the caller
     // Shared between all hoverified code views
     const container = createObservableStateContainer<InternalHoverifierState<C>>({
         hoverOverlayIsFixed: false,
         clickedGoToDefinition: false,
         definitionURLOrError: undefined,
-        referencesURL: undefined,
         hoveredToken: undefined,
         hoverOrError: undefined,
         hoverOverlayPosition: undefined,
@@ -537,13 +532,6 @@ export function createHoverifier<C extends object>({
         distinctUntilChanged((a, b) => isEqual(a.position, b.position))
     )
 
-    /** Emits new referencesURL values. */
-    subscription.add(
-        resolvedPositions
-            .pipe(map(({ position }) => (position ? getReferencesURL(position) : null)))
-            .subscribe(referencesURL => container.update({ referencesURL }))
-    )
-
     /**
      * For every position, emits an Observable with new values for the `hoverOrError` state.
      * This is a higher-order Observable (Observable that emits Observables).