feat: remove telemetry event logging

Author: sqs

src/HoverOverlay.tsx

@@ -1,5 +1,5 @@
 import { LoadingSpinner } from '@sourcegraph/react-loading-spinner'
-import { castArray, noop, upperFirst } from 'lodash'
+import { castArray, upperFirst } from 'lodash'
 import AlertCircleOutlineIcon from 'mdi-react/AlertCircleOutlineIcon'
 import CloseIcon from 'mdi-react/CloseIcon'
 import InformationOutlineIcon from 'mdi-react/InformationOutlineIcon'
@@ -78,8 +78,6 @@ export interface HoverOverlayProps<C = {}> {
 
     /** Called when the close button is clicked */
     onCloseButtonClick?: (event: MouseEvent) => void
-
-    logTelemetryEvent?: (event: string, data?: any) => void
 }
 
 /** Returns true if the input is successful jump URL result */
@@ -100,7 +98,6 @@ export const HoverOverlay: <C>(props: HoverOverlayProps<C>) => React.ReactElemen
     onGoToDefinitionClick,
     overlayPosition,
     showCloseButton,
-    logTelemetryEvent = noop,
     className = '',
 }) => (
     <div
@@ -201,7 +198,6 @@ export const HoverOverlay: <C>(props: HoverOverlayProps<C>) => React.ReactElemen
                     <ButtonOrLink
                         linkComponent={linkComponent}
                         // tslint:disable-next-line:jsx-no-lambda
-                        onClick={() => logTelemetryEvent('FindRefsClicked')}
                         to={referencesURL}
                         className="btn btn-secondary hover-overlay__action e2e-tooltip-find-refs"
                     >

src/hoverifier.test.ts

@@ -46,7 +46,6 @@ describe('Hoverifier', () => {
                     fetchHover: createStubHoverFetcher(hover, delayTime),
                     fetchJumpURL: createStubJumpURLFetcher(defURL, delayTime),
                     pushHistory: noop,
-                    logTelemetryEvent: noop,
                 })
 
                 const positionJumps = new Subject<{
@@ -148,7 +147,6 @@ describe('Hoverifier', () => {
                     fetchHover,
                     fetchJumpURL,
                     pushHistory: noop,
-                    logTelemetryEvent: noop,
                 })
 
                 const positionJumps = new Subject<{

src/hoverifier.ts

@@ -1,4 +1,4 @@
-import { isEqual, noop } from 'lodash'
+import { isEqual } from 'lodash'
 import {
     combineLatest,
     concat,
@@ -83,11 +83,6 @@ export interface HoverifierOptions<C extends object> {
      */
     pushHistory: (path: string) => void
 
-    /**
-     * Called to log telemetry events
-     */
-    logTelemetryEvent?: (event: string, data?: any) => void
-
     fetchHover: HoverFetcher<C>
     fetchJumpURL: JumpURLFetcher<C>
     getReferencesURL: (hoverToken: HoveredToken & C) => string | null
@@ -196,7 +191,7 @@ export interface HoverState {
     /**
      * The props to pass to `HoverOverlay`, or `undefined` if it should not be rendered.
      */
-    hoverOverlayProps?: Pick<HoverOverlayProps, Exclude<keyof HoverOverlayProps, 'linkComponent' | 'logTelemetryEvent'>>
+    hoverOverlayProps?: Pick<HoverOverlayProps, Exclude<keyof HoverOverlayProps, 'linkComponent'>>
 
     /**
      * The currently selected position, if any.
@@ -300,7 +295,6 @@ export function createHoverifier<C extends object>({
     fetchHover,
     fetchJumpURL,
     getReferencesURL,
-    logTelemetryEvent = noop,
 }: HoverifierOptions<C>): Hoverifier<C> {
     // Internal state that is not exposed to the caller
     // Shared between all hoverified code views
@@ -641,18 +635,6 @@ export function createHoverifier<C extends object>({
                 token.classList.add('selection-highlight')
             })
     )
-    // Telemetry for hovers
-    subscription.add(
-        zip(resolvedPositions, hoverObservables)
-            .pipe(
-                distinctUntilChanged(([positionA], [positionB]) => isEqual(positionA, positionB)),
-                switchMap(([, hoverObservable]) => hoverObservable),
-                filter(({ hoverOrError }) => HoverMerged.is(hoverOrError))
-            )
-            .subscribe(() => {
-                logTelemetryEvent('SymbolHovered')
-            })
-    )
 
     /**
      * For every position, emits an Observable that emits new values for the `definitionURLOrError` state.
@@ -734,9 +716,6 @@ export function createHoverifier<C extends object>({
     // On every click on a go to definition button, reveal loader/error/not found UI
     subscription.add(
         goToDefinitionClicks.subscribe(event => {
-            // Telemetry
-            logTelemetryEvent('GoToDefClicked')
-
             // If we don't have a result yet that would be jumped to by the native <a> tag...
             if (!isJumpURL(container.values.definitionURLOrError)) {
                 // Prevent default link behaviour (jump will be done programmatically once finished)