This repository was archived by the owner on Nov 25, 2021. It is now read-only.
feat: conditionally tokenize cells #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguychard
approved these changes
Jun 7, 2019
Contributor
lguychard
left a comment
lguychard
left a comment
There was a problem hiding this comment.
I think this could benefit from a really simple unit test to make sure we don't regress on this.
felixfbecker
reviewed
Jun 7, 2019
Contributor
|
Agree on needing a test. |
chrismwendt
force-pushed
the
conditional-tokenization
branch
from
cc2661d to
b27d855
Compare
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
- Coverage 84.05% 83.98% -0.07%
==========================================
Files 13 13
Lines 533 537 +4
Branches 125 127 +2
==========================================
+ Hits 448 451 +3
- Misses 85 86 +1
Continue to review full report at Codecov.
|
chrismwendt
force-pushed
the
conditional-tokenization
branch
2 times, most recently
from
39870fe to
9ab3049
Compare
chrismwendt
force-pushed
the
conditional-tokenization
branch
from
9ab3049 to
6c94111
Compare
Contributor
Author
|
✅ Added a test. |
|
🎉 This PR is included in version 6.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: some code hosts have already tokenized the code view (e.g. Bitbucket). The tokenization currently prevents text selection from working on Bitbucket https://github.com/sourcegraph/sourcegraph/issues/4051
Implementation: this lets callers specify a boolean
tokenizeto control whether or not tokenization occurs.Slack conversation https://sourcegraph.slack.com/archives/CHXHX7XAS/p1559599129008000