This repository was archived by the owner on Nov 25, 2021. It is now read-only.
Conditionally tokenize code views (continued) #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
=========================================
+ Coverage 83.98% 84.1% +0.11%
=========================================
Files 13 13
Lines 537 541 +4
Branches 127 132 +5
=========================================
+ Hits 451 455 +4
Misses 86 86
Continue to review full report at Codecov.
|
felixfbecker
reviewed
Jun 8, 2019
| // Bitbucket, punctuation characters are not wrapped in tags and the | ||
| // current offset-finding logic can't determine the offset for such | ||
| // tokens. One way to fix that is to use the CodeMirror API | ||
| // directly. |
Contributor
There was a problem hiding this comment.
So we do need tokenization after all? I thought CodeMirror wrapped all tokens?
Contributor
Author
There was a problem hiding this comment.
As far as I can tell, only punctuation characters are not wrapped. Normal tokens are wrapped. Since that covers 99% of use cases, I think it's ok. WDYT?
lguychard
approved these changes
Jun 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #115 I forgot a few code paths where
convertNode()gets called.This adds a
tokenizeproperty tocreateHoverifierand plumbs it through a few of the token-finding functions.