Skip to content
This repository was archived by the owner on Nov 25, 2021. It is now read-only.

Conversation

@ijsnow
Copy link
Contributor

@ijsnow ijsnow commented Aug 7, 2018

Before, the object containing hoverOrError was being passed, not just hoverOrError.

@ijsnow ijsnow requested a review from dadlerj August 7, 2018 16:37
@codecov
Copy link

codecov bot commented Aug 7, 2018

Codecov Report

Merging #35 into master will increase coverage by 0.41%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   63.71%   64.13%   +0.41%     
==========================================
  Files          15       15              
  Lines         565      566       +1     
  Branches      146      146              
==========================================
+ Hits          360      363       +3     
+ Misses        205      203       -2
Impacted Files Coverage Δ
src/hoverifier.ts 58% <100%> (+1.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2da4cef...dea4156. Read the comment docs.

@ijsnow ijsnow merged commit 3997987 into master Aug 7, 2018
@ijsnow ijsnow deleted the telemetry-fix branch August 7, 2018 16:42
@sourcegraph-bot
Copy link

🎉 This PR is included in version 3.6.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@felixfbecker
Copy link
Contributor

Nice catch!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants