This repository was archived by the owner on Nov 25, 2021. It is now read-only.
Get full token fix #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 66.82% 66.08% -0.75%
==========================================
Files 15 15
Lines 615 631 +16
Branches 161 165 +4
==========================================
+ Hits 411 417 +6
- Misses 204 214 +10
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 3.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
|
||
| // Otherwise, we can't guarantee that the common ancester container doesn't contain | ||
| // whitespace or other characters around it. To solve for this case, we'll just | ||
| // surround the contents of the range with a new span. |
Contributor
There was a problem hiding this comment.
Can the range span multiple lines?
Contributor
Author
There was a problem hiding this comment.
I can't think of a case where a token would span multiple lines. Can you?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two closely related issues
commonAncestorContainerto be too high up in the tree and I, incorrectly, assumed that it couldn't. This PR fixes that.getTokenAtPosition. We still had a problem with placing the tooltip because the event targets weren't guaranteed to be the full token so we usegetTokenAtPositionto correct that.