fix(deps): update rxjs #52
Conversation
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 65.14% 65.14%
=======================================
Files 15 15
Lines 637 637
Branches 172 172
=======================================
Hits 415 415
Misses 222 222Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 3.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| "marked": "^0.4.0", | ||
| "mdi-react": "^4.0.0", | ||
| "rxjs": "^6.2.1", | ||
| "rxjs": "^6.3.2", |
There was a problem hiding this comment.
This release was already included in the previous range, was 6.2.1 actually not compatible with codeintellify anymore? In general it's good to have constraints be wide so consumers don't duplicate packages if not needed, i.e. only update package-lock.json in this repo as a chore (Renovate will do that) unless of course we depend on a new feature from a new version.
There was a problem hiding this comment.
I was seeing the “source” rxjs type error where one of the types had codeintellify in the path. I think it may have been unnecessary, but upgrading this and some other packages’ rxjs ended up fixing it.
There was a problem hiding this comment.
Next time you see an error I would be curious to see it, I want to get rid of them once and for all (see #49 and my PRs to rxjs)
There was a problem hiding this comment.
The root package in general has full power over what versions are pulled in (as long as ranges are compatible) and can update transitive dependencies (unlike MVS). So in theory you should not need to update all of our packages to use only the latest rxjs in the webapp.
No description provided.