Add 6.4 upgrade instruction for symbols #1117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The symbols service will no longer be needed in 6.4. We still publish it at the moment, but it won't do anything. All functionality is now handled by searcher and frontend. Existing set env vars should be moved to the searcher service, and resources may be reallocated to there as well. Test plan: We'll test this on dotcom and S2 for the next few weeks.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MaedahBatool
approved these changes
May 7, 2025
There was a problem hiding this comment.
LGTM, @eseliger. But it's a draft. Is it still a WIP, or can I merge?
This was referenced May 12, 2025
|
Moved it to review ready now! Wanted to talk to the team first :) |
jdpleiness
approved these changes
May 12, 2025
|
Thanks @eseliger! |
eseliger
added a commit
to sourcegraph/deploy-sourcegraph-k8s
that referenced
this pull request
May 12, 2025
Starting in Sourcegraph 6.4, the Symbols and Searcher services are now combined, for easier operation, simplified architecture, and better resource utilization. Customers can delete the service if not deleted automatically, and may want to consider reallocating resources previously given to symbols to searcher. Environment variables should be copied over from symbols to searcher. Test plan: This deployment ran for ~2 weeks on S2 and dotcom already and has signoff from team-product-platform. ## Checklist <!-- Kubernetes, both Kustomize and Helm, and Docker Compose MUST be kept in sync. You should not merge a change here without a corresponding change in the other repositories, unless it is specific to this deployment type. If uneeded, add link or explanation of why it is not needed here. --> - [ ] Update [CHANGELOG.md](https://github.com/sourcegraph/deploy-sourcegraph-k8s/blob/main/CHANGELOG.md) - [x] Update [K8s Upgrade notes](https://github.com/sourcegraph/sourcegraph/blob/main/doc/admin/updates/kubernetes.md): sourcegraph/docs#1117 - [x] Kustomiz-specific changes - [x] Update sister repository: [deploy-sourcegraph-helm](https://github.com/sourcegraph/deploy-sourcegraph-helm) - [x] Update sister repository: [deploy-sourcegraph-docker](https://github.com/sourcegraph/deploy-sourcegraph-docker) - [x] Verify all images have a valid tag and SHA256 sum
eseliger
added a commit
to sourcegraph/deploy-sourcegraph-helm
that referenced
this pull request
May 12, 2025
Starting in Sourcegraph 6.4, the Symbols and Searcher services are now combined, for easier operation, simplified architecture, and better resource utilization. Customers can delete the service if not deleted automatically, and may want to consider reallocating resources previously given to symbols to searcher. Environment variables should be copied over from symbols to searcher. Test plan: This deployment ran for ~2 weeks on S2 and dotcom already and has signoff from team-product-platform. ### Checklist - [ ] Follow the [manual testing process](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/TEST.md) - [x] Update [changelog](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph/CHANGELOG.md) - [x] Update [Kubernetes update doc](https://docs.sourcegraph.com/admin/updates/kubernetes): sourcegraph/docs#1117
enriquegh
pushed a commit
to sourcegraph/deploy-sourcegraph-helm
that referenced
this pull request
Jul 10, 2025
Starting in Sourcegraph 6.4, the Symbols and Searcher services are now combined, for easier operation, simplified architecture, and better resource utilization. Customers can delete the service if not deleted automatically, and may want to consider reallocating resources previously given to symbols to searcher. Environment variables should be copied over from symbols to searcher. Test plan: This deployment ran for ~2 weeks on S2 and dotcom already and has signoff from team-product-platform. ### Checklist - [ ] Follow the [manual testing process](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/TEST.md) - [x] Update [changelog](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph/CHANGELOG.md) - [x] Update [Kubernetes update doc](https://docs.sourcegraph.com/admin/updates/kubernetes): sourcegraph/docs#1117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symbols service will no longer be needed in 6.4. We still publish it at the moment, but it won't do anything. All functionality is now handled by searcher and frontend. Existing set env vars should be moved to the searcher service, and resources may be reallocated to there as well.
Test plan: We'll test this on dotcom and S2 for the next few weeks.