Skip to content

Conversation

@mibali
Copy link
Contributor

@mibali mibali commented Dec 30, 2024

Added The maximum number of repo-centric permissions syncing jobs that can be spawned concurrently in the site config doc .

@vercel
Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sourcegraph-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 3:32pm

Copy link
Contributor

@alexAtSourcegraph alexAtSourcegraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a re-write for clarity:

"Server restart is required for changes to take effect."

Copy link
Contributor Author

@mibali mibali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes!
Really appreciate the eagle eye!

"gitserver.diskUsageWarningThreshold": 90,

// Configuration for logging and alerting, including to external services.
// Configuration for logging and alerting, including to external s.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what "external s" means in this context. From the rest of this PR it seems that this is in reference to Slack?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If my assumption that we're simply updating the Slack hooks URL due to a change on Slack's end then we don't have to change this messaging to "external s" we can keep "external services".

Again, if I'm misunderstanding something please fill in the gap for me here.

// "channel": "#alerts",
// "type": "slack",
// "url": "https://hooks.slack.com/services/..."
// "url": "https://hooks.slack.com/s/..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would seem that Slack has updated their hooks URL?

If that is what we're trying to fix it would be helpful to have a reference for this change (reply to this comment with it).

Copy link
Contributor

@alexAtSourcegraph alexAtSourcegraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexAtSourcegraph alexAtSourcegraph merged commit 749a9f2 into main Jan 7, 2025
5 checks passed
@alexAtSourcegraph alexAtSourcegraph deleted the mibali-patch-2 branch January 7, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants