-
Couldn't load subscription status.
- Fork 76
Update site_config.mdx #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a re-write for clarity:
"Server restart is required for changes to take effect."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the changes!
Really appreciate the eagle eye!
docs/admin/config/site_config.mdx
Outdated
| "gitserver.diskUsageWarningThreshold": 90, | ||
|
|
||
| // Configuration for logging and alerting, including to external services. | ||
| // Configuration for logging and alerting, including to external s. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what "external s" means in this context. From the rest of this PR it seems that this is in reference to Slack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If my assumption that we're simply updating the Slack hooks URL due to a change on Slack's end then we don't have to change this messaging to "external s" we can keep "external services".
Again, if I'm misunderstanding something please fill in the gap for me here.
docs/admin/config/site_config.mdx
Outdated
| // "channel": "#alerts", | ||
| // "type": "slack", | ||
| // "url": "https://hooks.slack.com/services/..." | ||
| // "url": "https://hooks.slack.com/s/..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would seem that Slack has updated their hooks URL?
If that is what we're trying to fix it would be helpful to have a reference for this change (reply to this comment with it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added The maximum number of repo-centric permissions syncing jobs that can be spawned concurrently in the site config doc .