Skip to content

Decoupled filetree visitor from DocumentIndexer type and tracking javac error count #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 29, 2020
Merged

Decoupled filetree visitor from DocumentIndexer type and tracking javac error count #68

merged 6 commits into from
Oct 29, 2020

Conversation

@Strum355
Copy link
Contributor

@Strum355 Strum355 commented Oct 28, 2020

Three(two) big changes:

  • Decoupled the file tree visitor from creating the map of document indexers
    • made the file tree visitor asynchronous, sending results back on a channel to a coroutine that collects these into the resulting map
  • Tracking of javac errors to display at the end of project indexing
    • There are different types of these "counting diagnostics listeners"
      • /dev/null-esque when -javacOut = none
      • System.out when -javacOut = stdout
      • System.err when -javacOut = stderr
      • File-based when -javacOut = none of the above
  • Introduced interface for build-tools bridge

@Strum355
Introduced CountingDiagnosticListener and CanonicalPath types, Decoup…
5a1ee9d 
…led FileCollector from DocumentIndexer map and made it async

Decoupled the filetree visitor type from creating the documentindexer map by making the process async and sending discovered files down a channel
CanonicalPath simplifies some code that derives a canonical path from a basic Path type
CountingDiagnosticListener combines both an output writer and a counter for diagnostics. By implementing the DiagnosticListener, we can accurately count individual diagnostics rather than counting individual writes to a java.io.Writer, which is innacurate as a single diagnostic generally results in multiple write calls
@Strum355
Lazy eval'd index method for DocumentIndexer, some stylistic changes,…
9068dca 
… display total javac errors

Using lazy block for the DocumentIndexer index method to mimic Gos sync.Once
@Strum355
Support wider range of 'class' declaration types in the type name emi…
16bbcac 
…tted
@Strum355 Strum355 added type/enhancement New feature or request lib/com.sun.source For issues/PRs regarding the com.sun.source based lsif-java lsif-java team/code-intelligence labels Oct 28, 2020
@Strum355 Strum355 added this to the 3.22 milestone Oct 28, 2020
@Strum355 Strum355 requested a review from a team October 28, 2020 16:59
This was referenced Oct 28, 2020
Closed
Closed
@Strum355 Strum355 merged commit fe592f3 into nsc/comsunsource Oct 29, 2020
@Strum355 Strum355 deleted the nsc/comsunsource-kotlin3 branch October 29, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lib/com.sun.source For issues/PRs regarding the com.sun.source based lsif-java lsif-java team/code-intelligence type/enhancement New feature or request

Projects

None yet

Milestone

3.22

Development

Successfully merging this pull request may close these issues.

2 participants

@Strum355