WIP: Intercepting of javac calls with gradle #78
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strum355
added
lib/com.sun.source
efritz
approved these changes
Nov 12, 2020
Contributor
efritz
left a comment
efritz
left a comment
There was a problem hiding this comment.
why you hate newlines at end of file?
Contributor
Author
|
Ruins symmetry with the first line, having a final empty one 😤 feels like an awkward appendage 👀 |
This was referenced Nov 12, 2020
Contributor
|
Closing this as we're going with another approach as discussed offline. I will open a PR soon with the new approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.