Skip to content

Conversation

@Strum355
Copy link
Contributor

@Strum355 Strum355 commented Feb 4, 2021

For the next blessed soul who works on lsif-java, I must document the code well enough

@Strum355 Strum355 added lib/com.sun.source For issues/PRs regarding the com.sun.source based lsif-java lsif-java team/code-intelligence labels Feb 4, 2021
@Strum355 Strum355 added this to the Code Intelligence Sprint 5 milestone Feb 4, 2021
@Strum355 Strum355 requested a review from a team February 4, 2021 00:22
@Strum355 Strum355 self-assigned this Feb 4, 2021
@Strum355 Strum355 changed the title Documenting lsif-java WIP: Documenting lsif-java Feb 4, 2021
@Strum355 Strum355 changed the title WIP: Documenting lsif-java WIP: Documenting lsif-java ft. minor refactorings Feb 4, 2021
definitions[range] = DefinitionMeta(rangeId, resultSetId) // + contents?
}

// TODO(nsc): GLOBAL CACHE SO WE DONT HAVE MULTIPLE REFS FOR SAME DEF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol nice

@efritz
Copy link
Contributor

efritz commented Feb 4, 2021

Looks like Java to me.

Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@olafurpg olafurpg marked this pull request as ready for review February 10, 2021 14:24
@olafurpg olafurpg merged commit 7bb9cdc into nsc/comsunsource Feb 10, 2021
@olafurpg olafurpg deleted the nsc/comsunsource-documented branch February 10, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib/com.sun.source For issues/PRs regarding the com.sun.source based lsif-java lsif-java team/code-intelligence

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants