Disable checkerframework Gradle plugin for lsif-java index
#314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improves the formatting of the `--verbose` option.
olafurpg
changed the title
lsif-java index
Strum355
reviewed
Aug 25, 2021
Comment on lines
+84
to
+87
| // Disable the checkerframework plugin because it updates the processorpath | ||
| // in a way that causes the error "plug-in not found: semanticdb". | ||
| // Details: https://github.com/kelloggm/checkerframework-gradle-plugin/blob/76d1926ae22144b082dfcfde1abe625750469398/src/main/groovy/org/checkerframework/gradle/plugin/CheckerFrameworkPlugin.groovy#L374-L376 | ||
| "-PskipCheckerFramework", |
There was a problem hiding this comment.
Strange that we need this, the commit that added this logic specifically mentions not overwriting the existing annotationProcessor path 🤔 kelloggm/checkerframework-gradle-plugin@3db37da
There was a problem hiding this comment.
What's stranger is that I validated that SemanticdbAgent is updating the processorpath correctly. It looks like a Gradle initialization order issue to me that's difficult to fix. It's easy to disable the checker framework so I went with this approach instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
lsif-java indexfailed to work in projects using the Gradle plugin https://github.com/kelloggm/checkerframework-gradle-plugin combined with Java toolchains. This PR fixes the bug by disabling the checkerframework plugin by default when runninglsif-java index