ci: Cache Bazel data from linting step #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, we keep rebuilding protoc from scratch (as a dependency of Buildifier...?) which doesn't make sense. We should just cache things. Ideally, we would just depend on pre-built buildifier binaries, such as in https://github.com/keith/buildifier-prebuilt, but we don't want to have divergence in the build config from upstream, if possible.
varungandhi-src
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we keep rebuilding protoc from scratch
(as a dependency of Buildifier...?) which takes several
minutes, making the linting step slower than the
ci.yml workflow. We should just cache things.
Ideally, we would just depend on pre-built buildifier
binaries, such as in https://github.com/keith/buildifier-prebuilt,
but we don't want to have divergence in the build
config from upstream, if possible.
Test plan
See if linting step speeds up in subsequent PRs.