Misc improvements & resolve open issues #13
Conversation
oliviernotteghem
commented
Apr 9, 2020
oliviernotteghem
commented
- Disable search menu entry when no text is selected.
- Fix handling of local branch
- Move menu entries into sub-menu
- Implement copy link functionality
- Use Project storage API to load config from
- Fix handling of local branch - Move menu entries into sub-menu - Implement copy link functionality - Use Project storage API to load config from
|
Apologies for the delay on this, I’ll review and merge soon! |
|
Thanks for the PR @oliviernotteghem -- this is really cool, I especially like the icon and submenu! I pushed some minor changes here: #14 One problem with this approach.. I notice this doesn't appear in the editor preferences UI which is what #11 and #7 seem to indicate we should be doing. It seems this just changes the configuration from a manual I think we need to do something like this: http://corochann.com/intellij-plugin-development-introduction-applicationconfigurable-projectconfigurable-873.html#Making_classimplements_Configurable I would merge this as-is, because the bug fixes are good, but one problem sticks out to me with this approach in particular:
|
|
Yeah, I'd love to! I could do the following times:
Do either of those work for you? If yes just send me an invite to stephen@sourcegraph.com |
I think we could solve this by having two actions: "Search" (global) and "Search in repository" Only question is: could we come up with another keyboard shortcut that makes sense? Maybe Option+R ? This change will also require a change on the Sourcegraph.com side so that |
|
Hey @oliviernotteghem I am working on:
|
|
@oliviernotteghem any chance you could take a quick look at my last message? I'd love to land this soon |
|
Sorry, I somehow missed it. .idea/sourcegraph.xml will be generated automatically whenever you close project / IDE, provided you specific data. So just invoke setter (instead of getter) in your code, run it, close IDEA, and you should see the file. for the shortcut key combo : sounds good to me. |
This adds support for editors having the following actions: 1. Search in repository 2. Search in repository@branch 3. Search in repository@rev 4. Search in file In practice, I imagine only the first one will be used for now and later someone may request support for 2/3/4. In specific, the first one will be implemented in Jetbrains editors via sourcegraph/sourcegraph-jetbrains#13
…repository" (#10586) * editor: refactor HTTP handler for testing * editor: add tests for editor HTTP handler * editor: refactor HTTP handler to be more legible + fix bugs * editor: produce proper ?patternType=literal URLs instead of using quotes-in-regexp-search * add comment * editor: add support for "search in repository/file" This adds support for editors having the following actions: 1. Search in repository 2. Search in repository@branch 3. Search in repository@rev 4. Search in file In practice, I imagine only the first one will be used for now and later someone may request support for 2/3/4. In specific, the first one will be implemented in Jetbrains editors via sourcegraph/sourcegraph-jetbrains#13 * Update cmd/frontend/internal/app/editor.go Co-authored-by: ᴜɴᴋɴᴡᴏɴ <joe@sourcegraph.com> * Update cmd/frontend/internal/app/editor.go Co-authored-by: ᴜɴᴋɴᴡᴏɴ <joe@sourcegraph.com> * Update cmd/frontend/internal/app/editor.go Co-authored-by: ᴜɴᴋɴᴡᴏɴ <joe@sourcegraph.com> * address comments Co-authored-by: ᴜɴᴋɴᴡᴏɴ <joe@sourcegraph.com>
|
Merged via #14 |
2 participants
