Basic code intel: no results on TypeScript j2d

[chrismwendt]

• Visit https://k8s.sgdev.org/github.com/sourcegraph/javascript-typescript-langserver@21e4bf0f2a57bc85caa44c107fe24910b1a959aa/-/blob/src/logging.ts#L56:78&tab=def
• Click on j2d
• Notice there are no definition results

[chrismwendt]

This fixes it (not sure why yet, still looking)

diff --git a/extension/src/extension.ts b/extension/src/extension.ts
index 16bd2d6..be9a18d 100644
--- a/extension/src/extension.ts
+++ b/extension/src/extension.ts
@@ -583,8 +583,11 @@ export async function activate(ctx: sourcegraph.ExtensionContext): Promise<void>
         )
         providers.add(
             sourcegraph.languages.registerDefinitionProvider(documentSelector, {
-                provideDefinition: distinctUntilChanged(areProviderParamsEqual, (textDocument, position) =>
-                    observableFromAsyncIterable(provideDefinition(textDocument, position))
+                provideDefinition: distinctUntilChanged(
+                    areProviderParamsEqual,
+                    async (textDocument, position) =>
+                        // observableFromAsyncIterable(provideDefinition(textDocument, position))
+                        await basicCodeIntel.definition(textDocument, position)
                 ),
             })
         )

Bisecting says I broke this in sourcegraph/sourcegraph-typescript#229