Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Conversation

@kevinburke
Copy link
Contributor

I don't think they add much in particular and they make us look bad if
the build is failing. It's easy to see whether the build is failing
because the build status is present on any PR/tip commit on master,
and you can tell we use prettier because the build will fail if your
formatting doesn't match it.

This PR does not need to update the CHANGELOG because it's trivial.

@kevinburke kevinburke force-pushed the remove-icons branch 4 times, most recently from 11fd682 to e8e9a35 Compare October 1, 2018 19:34
I don't think they add much in particular and they make us look bad if
the build is failing. It's easy to see whether the build is failing
because the build status is present on any PR/tip commit on master,
and you can tell we use prettier because the build will fail if your
formatting doesn't match it.
@kevinburke kevinburke merged commit af955a8 into master Oct 1, 2018
@nicksnyder nicksnyder deleted the remove-icons branch October 1, 2018 19:49
@felixfbecker
Copy link
Contributor

I don't think they add much in particular and they make us look bad if
the build is failing.

Yeah, and they should make us look bad if the build is failing. If the build is failing and that makes us look bad the solution is to fix the build, not remove the badge. That's like putting tape over the lamp in your car telling you your engine needs maintenance. A build badge is a useful indicator of whether I can currently build the project from master, and they are so ubiquitous that not having one makes us look bad. If I don't see a build badge in a project I literally assume it has no CI (and I would not check the commit page first). Also, we use badges in every other of our repos, even though the same argument could be made everywhere. In fact, you could make that argument for every open source project out there, yet every open source project I can think of has them, so clearly the majority of people like them. I was okay with removing the codecov badge which revealed an ugly truth about our codebase, because it is not easily fixable. But the build badge should show a green status 99.99% of the time, so its net impact on people's impression of our repo will be positive, not negative.

@felixfbecker felixfbecker mentioned this pull request Oct 2, 2018
BolajiOlajide pushed a commit that referenced this pull request Apr 16, 2024
Previously we only directed the user to the logfile, but there are some
errors that are independent of the action's step: failing to fetch the
ZIP archive, failing to extract ZIP archive, etc.

Those are not in the logfiles and as it turns out we never logged them.

This change fixes that.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants